Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage updates #213

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Storage updates #213

merged 5 commits into from
Jun 20, 2024

Conversation

kilianp14
Copy link
Contributor

  • Updated co-simulation infrastructure to avoid wrong order of execution of simulators by mosaik
  • Updated way of setting storage/policy parameters during simulation. Now parameters are set from controllers in the following way: self.set_parameters["policy:charge_power"] = 10 or self.set_parameters["storage:min_soc"] = 0.3
  • Former actor_infos passed to controllers every step is now state and also contains the storage and policy state next to the actor states (This is not yet updated in the SilController)
  • Storage api has been updated to represent the paper version and now uses Wh instead of Ws both externally and internally:
    storage = vs.SimpleBattery(capacity=1500, initial_soc=0.8, min_soc=0.5)
  • SimpleBattery soc and min_soc should now no longer be sensitive to floating point operations (closes SimpleBattery is sensitive to floating point imprecision #204)
  • Examples have been updated, but still need a bit of work
  • Small fixes and updates in the sil example
  • Updated tests and documentation (closes Improve documentation of storage module #117)

marvin-steinke
marvin-steinke reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@marvin-steinke marvin-steinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight this PR looks like a biggie, lets talk in the meeting haha

examples/util/example_node/sil_node.py
@@ -24,7 +24,7 @@ def _workload_sim(self):
time.sleep(2)

def start(self):
uvicorn.run(self.app, host="0.0.0.0", port=self.port)
uvicorn.run(self.app, host="127.0.0.1", port=self.port)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this matter?

@kilianp14 kilianp14 merged commit 0a6a3d2 into main Jun 20, 2024
4 checks passed
@kilianp14 kilianp14 deleted the storage_updates branch June 20, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvin-steinke marvin-steinke marvin-steinke approved these changes

@birnbaum birnbaum Awaiting requested review from birnbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleBattery is sensitive to floating point imprecision Improve documentation of storage module
2 participants
@kilianp14 @marvin-steinke